Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSRC-110: FeaturedPageBlock #1723

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

DSRC-110: FeaturedPageBlock #1723

wants to merge 2 commits into from
+573 −0

Conversation

jamesbiggs
Copy link
Collaborator

@jamesbiggs jamesbiggs commented Sep 23, 2024 •
edited
Loading

Ticket URL: DSRC-110

About these changes

Adds a FeaturedPageBlock to the General and Focused/Article pages.

Will need to remove FeaturedRecordArticleBlock in the future as this will be deprecated, and migrate the data from those to the new FeaturedPageBlock. Another ticket has been created for this.

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • Added/updated tests and documentation where relevant

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

@jamesbiggs jamesbiggs marked this pull request as ready for review October 10, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahosgood ahosgood ahosgood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbiggs @ahosgood